SmithingPlusPlus

Hiya!

I made this fork because the original smithing plus mod hasn't been updated since May. There are many outstanding bugs and performance problems that require hacky patches to fix, so I decided to release the version I have been using that has been fully patched. 

 

I will maintain this fork as long as its allowed to exist, IE Jayu requests its removal. 

 

 

See original post for the description of the mod: https://mods.vintagestory.at/smithingplus

 

Potential mod compatability issues:

 

Since the moddb doesn't let 2 mods have the same modid, I implemented a patch that should allow mods that are looking for smithingplus to work with smithingplusplus. I can't say with 100% confidence that this works with all mods though.

Toolsmith specifically was tested and works without issue. Let me know if you do run into any problems, I might be able to do something but odds are the mod author will need to include smithingplusplus into their compat checks. 

 

Let me know if mods that add compatiblity with SmithingPlus work or dont work. I'll create a list so its known.

 

WARNING:

Do not install both SmithingPlusPlus AND SmithingPlus. They are the "same" mod and will conflict. Also, make sure to backup your world just in case. I have not had any issues on my in-progress world, but its better to be cautious and I'm not responsible for this bricking your save (it honestly doesn't change anything that should brick your save).

 

 

Special thanks to Jayu for making, what I consider, a required mod for any modded playthrough!

 

Working compatibility from mods:

• Toolsmith - Tested pretty thoroughly.
• Almanac - (not verified, a user in the comments stated it has compat now)

 

Known incompatiblity from mods:

 

 

Mod Settings Changes - as of v1.10.4

 

There is now a config version so config migrations can take place without clobbering your existing configs.

 

The server is now authoritative over mod settings. This means that when a user connects to a dedicated server, the servers config for SmithingPlusPlus will take priority. This fixes a huge bug where the client and server would be out of sync and the client would have all sorts of weird interactions.

 

There are 5 client-side only settings that the client can still change. BUT there is a new config option "ServerOverridesClientSettings" that servers can set if they want to control how their players interact with SmithingPlusPlus on their servers (This is false by default). 

 

Client-side Settings:

• AnvilRecipeSelectionColumns
• HandbookExtraInfo
• ShowWorkableTemperature
• RememberHammerToolMode
• AnvilShowRecipeVoxels

 

 

• Removed the long freeze the first time you look at an anvil. Metal material lookups are cached, including "no metal" results, and recipes are indexed by ingredient instead of rescanned for every item. The freeze scaled with items multiplied by recipes, so large modpacks were greatly affected.
• Fixed a crash when hovering over an anvil recipe in the selector.
• Fixed a crash on items that are anvil-workable but declare no voxels.
• Fixed items with random voxel patterns placing a different shape than the one measured, so placement could fail or misplace.
• Chisels no longer hold for 1.5 seconds on every target; the hold now only applies when scraping a crucible.
• Iron blooms and other items stating their own workable temperature no longer recompute it every tooltip frame.
• Behaviours are now replaced rather than duplicated when re-added.
• Fixed the game's server and client sides sharing one cache of pre-calculated data in singleplayer, where both run inside the same program, so each could end up using the other's. They now each keep their own.
• Fixed ingredient matching picking up tools that a recipe consumes.
• Fixed hammer strikes sometimes acting twice, moving a voxel further than the hit should. The client and server disagreed over which tool mode meant "flip", so one click could flip on one side and hammer on the other.
• Fixed the hammer mode being stuck on Heavy Hit when "remember last hammer mode" is enabled. The remembered mode overrode every selection instead of only applying to a hammer that had no mode set.
• Fixed duplicate broken tool heads when another mod handles tool damage, such as Toolsmith. The head used to drop when a tool was predicted to break, so a Toolsmith tool dropped one whenever its handle or binding broke, not just its head. It now drops only when the tool is actually destroyed.
• Fixed a tool with no matching head recipe being searched for on every single break instead of once, since "no recipe" was never remembered.
• Fixed a crash and a divide-by-zero when a mold priced itself against a malformed smithing recipe.
• Refactored code base -- this was mostly to make it easier to understand and for my own coding rules that I use.
• Fixed in singleplayer, SmithingPlus's caches were shared between the client and the server, so a cast tool head placed on an anvil could get the client's copy of the work item. The server then threw errors while spawning slag particles, before it could remove the slag. Rotating the item would then reshow the removed slag as it resynced to the servers version. The fix gives each side its own caches, so the server always uses its own items.

 

 

 

 

AI Notice: AI was used during the updating of this project. All code is reviewed and tested by a human (me).